Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Entity Mapping trait #34

Merged
merged 1 commit into from Aug 30, 2018

Conversation

3 participants
@JanGalek
Copy link
Contributor

JanGalek commented Aug 21, 2018

resolve #33

alternative for IEntityProvider.

@JanGalek JanGalek force-pushed the JanGalek:master branch 3 times, most recently from d37b5f9 to 7e202a5 Aug 21, 2018

@JanGalek

This comment has been minimized.

Copy link
Contributor Author

JanGalek commented Aug 27, 2018

Today I will send rebase ;)

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Aug 27, 2018

How is it working? I think it can't.

@JanGalek

This comment has been minimized.

Copy link
Contributor Author

JanGalek commented Aug 27, 2018

@f3l1x After rebase (+- 19-20h) trait will work in this way:

  • find annotationDriver
  • add Paths

you will use:

class ForumExtension extends CompilerExtension
{
    use EntityMapping;

    public function loadConfiguration(): void
    {
	...
        $this->setEntityMappings([
            'Forum' => __DIR__ . '/../Entity',
        ]);
    }
}

I have it in my project and work it ;)

@JanGalek JanGalek force-pushed the JanGalek:master branch 5 times, most recently from 78db830 to b15d6f5 Aug 27, 2018

use Nette\DI\ContainerBuilder;
use Nette\DI\MissingServiceException;
trait EntityMapping

This comment has been minimized.

@f3l1x

f3l1x Aug 30, 2018

Member

Prefix with T please.

/**
* @param string[] $mapping
* @throws MissingServiceException

This comment has been minimized.

@f3l1x

f3l1x Aug 30, 2018

Member

Drop throws

@JanGalek JanGalek force-pushed the JanGalek:master branch from b15d6f5 to 9d266b2 Aug 30, 2018

Added Entity Mapping trait
Added example EntityMapping

@JanGalek JanGalek force-pushed the JanGalek:master branch from 9d266b2 to f4a89f8 Aug 30, 2018

@JanGalek

This comment has been minimized.

Copy link
Contributor Author

JanGalek commented Aug 30, 2018

@f3l1x thanks, resolved CR ;)

@f3l1x f3l1x merged commit 6678991 into nettrine:master Aug 30, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@JanGalek

This comment has been minimized.

Copy link
Contributor Author

JanGalek commented Aug 30, 2018

@f3l1x thanks, I will look to qa (new PR)

@JanMikes

This comment has been minimized.

Copy link
Contributor

JanMikes commented Sep 23, 2018

Hi, @f3l1x any ETA when this finds its way into stable version?

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Sep 24, 2018

I hope soon. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.