AbstractDnsRecord: equals() and hashCode() to ignore name field's case #15330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Jul 29, 2025
### What changes were proposed in this pull request? This PR aims to Upgrade Netty to 4.1.123.Final. ### Why are the changes needed? To bring the latest bug fixes and also improvement. - https://netty.io/news/2025/07/16/4-1-123-Final.html - netty/netty#15428 - netty/netty#15425 - netty/netty#15414 - netty/netty#15422 - netty/netty#15410 - netty/netty#15393 - netty/netty#15376 - netty/netty#15368 - netty/netty#15330 - netty/netty#15346 - netty/netty#15357 - netty/netty#15355 - netty/netty#15308 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51693 from dongjoon-hyun/SPARK-52983. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In certain situations, it was found that DNS server implementations may return a response to a DNS question with a case other than that in the original request. In these cases, netty was found to continue waiting for additional responses, eventually timing out as if it had not received an answer to the DNS question.
This PR intends to make DNS answers match DNS questions when they vary only by case.
Modification:
AbstractDnsRecord's equals() and hashCode() methods now behave the same regardless of the name field's case
Result:
Fixes #15327 on the
4.1branch.