Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractByteBuf performance regression when use ByteBufProcessor #2653

Closed
normanmaurer opened this issue Jul 14, 2014 · 0 comments
Closed

AbstractByteBuf performance regression when use ByteBufProcessor #2653

normanmaurer opened this issue Jul 14, 2014 · 0 comments
Assignees
@normanmaurer
Labels
defect
Milestone
4.0.22.Final

Comments

@normanmaurer
Copy link
Member

I introduced a performance regression while doing the changes as part of 6c47cc9. The performance regression was caused by not-needed range checks.
@normanmaurer normanmaurer added this to the 4.0.22.Final milestone Jul 14, 2014
normanmaurer pushed a commit that referenced this issue Jul 14, 2014
[#2653] Remove uncessary range checks for performance reasons
ccd8859 
Motivation:

I introduced range checks as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove range checks where not needed

Result:

Fixed performance regression.
normanmaurer pushed a commit that referenced this issue Jul 14, 2014
[#2653] Remove uncessary range checks for performance reasons
115b246 
Motivation:

I introduced range checks as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove range checks where not needed

Result:

Fixed performance regression.
normanmaurer pushed a commit that referenced this issue Jul 14, 2014
[#2653] Remove uncessary range checks for performance reasons
93c3066 
Motivation:

I introduced range checks as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove range checks where not needed

Result:

Fixed performance regression.
normanmaurer pushed a commit that referenced this issue Jul 14, 2014
[#2653] Remove unnecessary ensureAccessible() calls
c4d0a87 
Motivation:

I introduced ensureAccessible() class as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove calls where not needed.

Result:

Fixed performance regression.
normanmaurer pushed a commit that referenced this issue Jul 14, 2014
[#2653] Remove unnecessary ensureAccessible() calls
f88dfd0 
Motivation:

I introduced ensureAccessible() class as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove calls where not needed.

Result:

Fixed performance regression.
normanmaurer pushed a commit that referenced this issue Jul 14, 2014
[#2653] Remove unnecessary ensureAccessible() calls
7e76cbd 
Motivation:

I introduced ensureAccessible() class as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove calls where not needed.

Result:

Fixed performance regression.
@normanmaurer normanmaurer self-assigned this Aug 14, 2014
pulllock pushed a commit to pulllock/netty that referenced this issue Oct 19, 2023
[netty#2653] Remove uncessary range checks for performance reasons
53c8496 
Motivation:

I introduced range checks as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove range checks where not needed

Result:

Fixed performance regression.
pulllock pushed a commit to pulllock/netty that referenced this issue Oct 19, 2023
[netty#2653] Remove unnecessary ensureAccessible() calls
ea35489 
Motivation:

I introduced ensureAccessible() class as part of 6c47cc9 in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove calls where not needed.

Result:

Fixed performance regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
defect
Projects
None yet
Milestone
4.0.22.Final
Development

No branches or pull requests
1 participant
@normanmaurer