Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2 HTTP translation layer state tracking #3619

Closed
Scottmitch opened this issue Apr 11, 2015 · 1 comment
Closed

HTTP/2 HTTP translation layer state tracking #3619

Scottmitch opened this issue Apr 11, 2015 · 1 comment
Assignees
@Scottmitch
Labels
improvement
Milestone
4.1.0.CR7

Comments

@Scottmitch
Copy link
Member

The HTTP translation layer currently maintains its own map to track stream state. This may be more overhead that is necessary and issue #3596 is investigating improving the state to be associated with streams. After this issue is resolved we should update the HTTP translation layer to take advantage of it.
@Scottmitch Scottmitch self-assigned this Apr 11, 2015
@Scottmitch Scottmitch added this to the 4.1.0.Beta5 milestone Apr 11, 2015
@Scottmitch
Copy link
Member Author

This will begin after @nmittler's #3593 PR.

@normanmaurer normanmaurer modified the milestones: 4.1.0.Beta5, 4.1.0.Beta6 May 7, 2015
@normanmaurer normanmaurer modified the milestones: 4.1.0.Beta6, 4.1.0.RC1 Sep 2, 2015
@normanmaurer normanmaurer modified the milestones: 4.1.0.CR1, 4.1.0.Final Nov 27, 2015
@Scottmitch Scottmitch mentioned this issue Jan 29, 2016
Closed
Scottmitch added a commit to Scottmitch/netty that referenced this issue Feb 1, 2016
@Scottmitch
InboundHttp2ToHttpAdapter leak and logic improvements
5f154a5 
Motivation:
In HttpConversionUtil's toHttpRequest and toHttpResponse methods can
allocate FullHttpMessage objects, and if an exeception is thrown during
the header conversion then this object will not be released. If a
FullHttpMessage is not fired up the pipeline, and the stream is closed
then we remove from the map, but do not release the object. This leads
to a ByteBuf leak. Some of the logic related to stream lifetime management
and FullHttpMessage also predates the RFC being finalized and is not correct.

Modifications:
- Fix leaks in HttpConversionUtil
- Ensure the objects are released when they are removed from the map.
- Correct logic and unit tests where they are found to be incorrect.

Result:
Fixes netty#4780
Fixes netty#3619
@normanmaurer normanmaurer modified the milestones: 4.1.0.Final, 4.1.0.CR7 Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmitch Scottmitch

Labels
improvement
Projects
None yet
Milestone
4.1.0.CR7
Development

Successfully merging a pull request may close this issue.

InboundHttp2ToHttpAdapter leak and logic improvements Scottmitch/netty
2 participants
@normanmaurer @Scottmitch