Correctly handle wildcard address when bind to socket and using nativ… #4770
Conversation
|
@trustin @Scottmitch PTAL... This was reported in the Cassandra issue tracker: |
normanmaurer
force-pushed
the
wildcard_address
branch
from
d5cbd3c
to
54ce69a
Compare
| @@ -54,7 +54,7 @@ public void setup() { | |||
| server = (EpollServerSocketChannel) bootstrap.group(GROUP) | |||
| .channel(EpollServerSocketChannel.class) | |||
| .handler(new ChannelInboundHandlerAdapter()) | |||
| .bind(new InetSocketAddress(0)).syncUninterruptibly().channel(); | |||
| .bind(new InetSocketAddress(NetUtil.LOCALHOST4, 0)).syncUninterruptibly().channel(); | |||
There was a problem hiding this comment.
This is needed to explicit bind on ipv4
There was a problem hiding this comment.
can you explain this change?
There was a problem hiding this comment.
yes.. this is needed as when you use new InetSocketAddress(0) it basically creates a wildcard address (0.0.0.0:port). The EpollSocketTcpMd5Test expect to have the server bound to ipv4 address.
There was a problem hiding this comment.
Not a big deal but would use LOCALHOST provide any value by allowing for more variation (depending on environment)?
There was a problem hiding this comment.
nope as LOCALHOST may be an ipv6 address.
There was a problem hiding this comment.
What I'm asking is would s/LOCALHOST4/LOCALHOST/g in this file provide any benefit?
There was a problem hiding this comment.
I know what you are asking but NetUtil.LOCALHOSTmay be an ipv6 address. We need to ensure we always use an ipv4 one.
…e transport Motivation: When a wildcard address is used to bind a socket and ipv4 and ipv6 are usable we should accept both (just like JDK IO/NIO does). Modifications: Detect wildcard address and if so use in6addr_any Result: Correctly accept ipv4 and ipv6
|
lgtm! |
normanmaurer
force-pushed
the
wildcard_address
branch
from
54ce69a
to
11e16a8
Compare
…e transport
Motivation:
When a wildcard address is used to bind a socket and ipv4 and ipv6 are usable we should accept both (just like JDK IO/NIO does).
Modifications:
Detect wildcard address and if so use in6addr_any
Result:
Correctly accept ipv4 and ipv6