Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 65: Provide distribution stats in HashedWheelTimer #682

Merged
merged 1 commit into from
Oct 26, 2012
Merged

Issue 65: Provide distribution stats in HashedWheelTimer #682

merged 1 commit into from
Oct 26, 2012

Conversation

obergner
Copy link
Contributor

Contents

  • An abstraction layer for Metrics/Monitoring Providers, providding
    • ValueMonitor, track an arbitrary datum's current value
    • ValueDistributionMonitor, track a long value's distribution
    • CounterMonitor, increase/decrease a long value
    • EventRateMonitor, track the rate which an event occurs at
  • A default implementation of the aforementioned abstraction layer based on Yammer Metrics
  • Support for pluggable Monitoring Providers based on Java 6's ServiceLoader
  • A modified HashedWheelTimer that tracks
    • number of Timeouts executed per second and
    • the distribution of the (absolute) deviation between scheduled and actual Timeout execution time

Suggestions

  • Using this feature, implement a ChannelHandler that tracks to overall number of incoming/outgoing bytes
  • Using this feature, implement a ChannelHandler that tracks the rate of incoming/outgoing PDUs
  • Using this feature, enhance DefaultChannelGroup to (optionally) track the number of connected channels
  • ...

Hope you find this useful.

Cheers,
Olaf

@normanmaurer
Copy link
Member

Could you please rebase your work ?

@obergner
Copy link
Contributor Author

That was the very last thing I did before issuing this pull request. But I will do so again once I get home later.

@normanmaurer
Copy link
Member

Also would be nice to squash them

Sent from my iPhone. Excuse any typos....

Am 25.10.2012 um 17:11 schrieb obergner notifications@github.com:

That was the very last thing I did before issuing this pull request. But I will do so again once I get home later.

—
Reply to this email directly or view it on GitHub.

@obergner
Copy link
Contributor Author

Into just one commit?

@normanmaurer
Copy link
Member

yes

Von meinem iPad gesendet

Am 25.10.2012 um 18:25 schrieb obergner notifications@github.com:

Into just one commit?

—
Reply to this email directly or view it on GitHub.

@obergner
Issue #65: Provide distribution stats for HashedWheelTimer
ddd0734 
First cut at implementing a generic abstraction layer for pluggable
metrics providers. This first cut is closely modeled after Yammer
Metrics. It remains to be seen if it is indeed flexibel enough to
support other providers.
Provide a default implementation of this new abstraction layer
based on Yammer Metrics.
Support pluggable Monitoring Providers using Java 6's ServiceLoader.
Use this new abstraction layer to provide stats on (a) number of
Timeouts executed per second and (b) distribution of absolute
deviation between scheduled and actual Timeout execution time in
HashedWheelTimer.
 * Interface ValueDistributionMonitor, a monitor for histograms.
 * Interface EventRateMonitor, a monitor for measuring the rate per time
   unit of specific events.
 * Interface ValueMonitor, a monitor for tracking an arbitrary datum's
   current value
 * Interface CounterMonitor, a monitor for incrementing/decrementing a
   long value
 * Interface MonitorRegistry, a registry for monitors that serves as the
   interface between Netty and concrete metrics providers as e.g. Yammer
   Metrics.
 * Interface MonitorRegistryFactory, to be implemented by metrics
   providers.
 * Document how to use Netty's new monitoring support in javadocs for
   package io.netty.monitor.
@obergner
Copy link
Contributor Author

All commits squashed into one and the result rebased on current master.

normanmaurer pushed a commit that referenced this pull request Oct 26, 2012
Merge pull request #682 from obergner/issue_65
e5319b6 
Add SPI to monitor netty. Also add stats for HashedWheelTimer to show how it can be used. See #65
@normanmaurer normanmaurer merged commit e5319b6 into netty:master Oct 26, 2012
@ghost ghost assigned normanmaurer Oct 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@normanmaurer normanmaurer

Labels
None yet
Projects
None yet
Milestone
4.0.0.Alpha6
Development

Successfully merging this pull request may close these issues.
2 participants
@obergner @normanmaurer