[Logging] Support use of loguru #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
kylesayrs
force-pushed
the
kylesayrs/loguru
branch
from
52d34ee to
d634e52
Compare
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
kylesayrs
changed the title
fynnsu
reviewed
Sep 9, 2025
brian-dellabetta
previously approved these changes
Sep 9, 2025
kylesayrs
changed the title
brian-dellabetta
previously approved these changes
Sep 9, 2025
fynnsu
previously approved these changes
Sep 9, 2025
* better type hints, warn once Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> * remove unneeded import Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> * use warnings Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> --------- Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
kylesayrs
dismissed stale reviews from fynnsu and brian-dellabetta
via
7391fc4
brian-dellabetta
approved these changes
Sep 10, 2025
fynnsu
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
Testing
deprecated, only log once #455