Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

version-api-pypi integration #114

Merged
merged 8 commits into from
Nov 15, 2021
Merged

version-api-pypi integration #114

merged 8 commits into from
Nov 15, 2021

Conversation

horheynm
Copy link

@horheynm horheynm commented Nov 3, 2021 •
edited
Loading

Completed:

  • Added get request for the version-api lambda's with the package_name and the package_version and temp holder of package_integration
  • Warns the user/client if they are not on the latest version
  • Run the api call in the background process using thread
  • Environmental variable to turn on/off the api-call
  • Make a call to staging-api.neuralmagic.com and save client info to staging DB

To-dos:

  • figure out how to put in the package_integration info
  • Add integration to other packages

@horheynm horheynm marked this pull request as draft November 3, 2021 16:24
@horheynm horheynm requested review from a team, natuan, bfineran and markurtz and removed request for a team November 3, 2021 16:24
@horheynm horheynm marked this pull request as ready for review November 5, 2021 01:24
@horheynm horheynm marked this pull request as draft November 5, 2021 01:25
markurtz
markurtz suggested changes Nov 10, 2021
View reviewed changes
@horheynm horheynm changed the title [WIP] version-api-pypi integration version-api-pypi integration Nov 12, 2021
@horheynm horheynm marked this pull request as ready for review November 12, 2021 22:12
bfineran
bfineran reviewed Nov 12, 2021
View reviewed changes
bfineran
bfineran previously approved these changes Nov 15, 2021
View reviewed changes
markurtz
markurtz suggested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@markurtz markurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change on None and currently we are not going to be pushing up the nightly tag

markurtz
markurtz previously approved these changes Nov 15, 2021
View reviewed changes
@markurtz markurtz merged commit a07f694 into main Nov 15, 2021
@jeanniefinks jeanniefinks deleted the pypi-version-api branch February 10, 2022 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@natuan natuan Awaiting requested review from natuan natuan was automatically assigned from neuralmagic/machine-learning

2 more reviewers

@markurtz markurtz markurtz approved these changes

@bfineran bfineran bfineran left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@horheynm @bfineran @markurtz