Skip to content

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Jun 25, 2017

Importer for the CSV export files of Padlock password manager:
https://padlock.io/

Signed-off-by: ßingen bingentxu@gmail.com

Importer for the CSV export files of Padlock password manager:
https://padlock.io/

Signed-off-by: ßingen <bingentxu@gmail.com>
@brantje brantje self-requested a review June 25, 2017 20:46
@animalillo
Copy link
Collaborator

it looks good to me, but this comment worries me: "TODO: Allow for new lines and commas in values"

@bingen
Copy link
Contributor Author

bingen commented Jun 26, 2017

So, the way it is now, if a password (or any other custom field) has a comma or a new line, it won't work. It's something to be improved, but I was able to import ~90 entries just removing one that has commas (which I imported manually) and manually deleting new lines from another one in advance. As commas and new lines are not so common in passwords, I think it's still useful. Let me know if I can clarify any further.

@animalillo
Copy link
Collaborator

I think that for it to be merged into the production system it should work if a password has a coma too!

You might only have 1 matching that pattern, but somebody might have a novel phrase as it's password! Who knows!

Have you tried if that works with the generic CSV importer?

@animalillo
Copy link
Collaborator

Also note that custom fields are custom for a reason, people might store something like that typical recovery questions having comas or something.

@bingen
Copy link
Contributor Author

bingen commented Jun 26, 2017

Ya, I tried with the generic CSV password and it wasn't working.

@bingen
Copy link
Contributor Author

bingen commented Jun 26, 2017

Ok, I was unlucky: I just picked the first one by alphabetical order as an example, which is not using PassmanImporter.readCsv.
Replacing this by #325

@bingen bingen closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants