-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4789: Group admins cannot see disabled users #7292
Fix #4789: Group admins cannot see disabled users #7292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contibution! 🚀🐘
Backport works with stable12 (tested on 12.0.4) |
This can fix some parts of this issue #6217 |
@MorrisJobke OK with me, the patch is nice and not risky in any case. |
works for me™ |
→ #8006 |
This is a trivial fix for the issue #4789, pointing out that a sub admin user (not a super user) cannot see the disabled users of their own group.
The problem dwells in
settings/Controller/UsersControllerlines
, in theindex
method, line 342 :This checks only if
$gid
is an empty string. If disabled users are listed,$gid
's value is_disabledUsers
and theelse
branch is executed, where no users are found, since there is not supposed to be a_disabledUsers
group.The PR simply mimics the same mechanics used some lines above if the current user is admin by adding to the check if
$gid
is_disabledUsers
or_everyone
.I would like to test this modification, but I couldn't find how.