fix(SmartPicker): Insert smart picker links as preview per default #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
changed the title
juliusknorr
reviewed
Jun 5, 2024
|
Can we also do this when using the smart picker with typing |
mejo-
force-pushed
the
fix/smart_picker_preview
branch
from
f53e454
to
f88e45e
Compare
Fixes: #5838 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/smart_picker_preview
branch
from
f88e45e
to
bc5f65c
Compare
mejo-
added
3. to review
enhancement
Yep, implemented now. |
juliusknorr
approved these changes
Jun 18, 2024
| attrs: { href: link, title: 'preview' }, | ||
| content: [{ | ||
| type: 'text', | ||
| marks: [{ |
There was a problem hiding this comment.
Seems a bit unexpected that the preview node still has an additional mark, can you tell why?
There was a problem hiding this comment.
I think it matches the data structure created otherwise. We basically change the wrapping block node between paragraph and preview when switching between the two:
The setPreview function above converts the surrounding paragraph of a link into a preview node:
If you look at unsetPreview above it also only unwraps the link inside the preview node:
|
/backport to stable29 |
mejo-
added a commit
that referenced
this pull request
Jun 19, 2024
Follow-up for #5846 Signed-off-by: Jonas <jonas@freesources.org>
2 tasks
backportbot bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Follow-up for #5846 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Jun 26, 2024
Follow-up for #5846 Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Behaviour:
/command as it's impossible to have ane editor selection when typing/🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)