Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 support #1296

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Drop Python 3.7 support #1296

merged 5 commits into from
Sep 5, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Aug 30, 2023

Description of proposed changes

Python 3.7 reached EOL ~2 months ago. Many dependencies have already dropped support in recent versions.

Use 3.8 as the minimum Python version.

Related issue(s)

N/A

Checklist

  • Checks pass
  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.

@victorlin victorlin self-assigned this Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
augur/argparse_.py ø
augur/export_v1.py 100.00%
augur/export_v2.py 100.00%

📢 Thoughts on this report? Let us know!.

@victorlin victorlin marked this pull request as ready for review August 30, 2023 18:31
@victorlin victorlin requested a review from a team August 30, 2023 18:31
@jameshadfield
Copy link
Member

This code can be removed once we've dropped 3.7, although I think fair to defer this to a subsequent PR if you'd prefer.

@victorlin
Copy link
Member Author

@jameshadfield I think that's reasonable to include in this PR! Added: 2da9d65

Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

This should have been done alongside 6b19842.
No reason not to use the latest available Python version.
Noticed this in passing. Just 2 days ago this wouldn't have been
possible!
Python 3.7 reached EOL ~2 months ago¹. Many dependencies have already
dropped support in recent versions.

Use 3.8 as the minimum Python version.

¹ https://devguide.python.org/versions/
This was in place since Python versions earlier than 3.8¹ don't support
the builtin action.

It can be removed now that Python 3.8 is the minimum supported version
for Augur.

¹ https://docs.python.org/3/library/argparse.html#action
@victorlin victorlin force-pushed the victorlin/update-python-versions branch from 2da9d65 to f691899 Compare September 5, 2023 17:56
@victorlin victorlin merged commit dfea585 into master Sep 5, 2023
23 checks passed
@victorlin victorlin deleted the victorlin/update-python-versions branch September 5, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants