-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.7 support #1296
Drop Python 3.7 support #1296
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
This code can be removed once we've dropped 3.7, although I think fair to defer this to a subsequent PR if you'd prefer. |
@jameshadfield I think that's reasonable to include in this PR! Added: 2da9d65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This should have been done alongside 6b19842.
No reason not to use the latest available Python version.
Noticed this in passing. Just 2 days ago this wouldn't have been possible!
Python 3.7 reached EOL ~2 months ago¹. Many dependencies have already dropped support in recent versions. Use 3.8 as the minimum Python version. ¹ https://devguide.python.org/versions/
This was in place since Python versions earlier than 3.8¹ don't support the builtin action. It can be removed now that Python 3.8 is the minimum supported version for Augur. ¹ https://docs.python.org/3/library/argparse.html#action
2da9d65
to
f691899
Compare
Description of proposed changes
Python 3.7 reached EOL ~2 months ago. Many dependencies have already dropped support in recent versions.
Use 3.8 as the minimum Python version.
Related issue(s)
N/A
Checklist