Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve Sidle container from quay.io/nf-core instead of docker.io/d4straub #729

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Retrieve Sidle container from quay.io/nf-core instead of docker.io/d4straub #729

merged 1 commit into from
Apr 2, 2024

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Apr 2, 2024 •
edited
Loading

For a new software (Sidle) I produced a container and deposited it at dockerhub. The processes that use that software did so with container 'docker.io/d4straub/pipesidle:0.1.0-beta'. My proposal to put the tool (pypi packaged) to conda was rejected by the developer of said tool. I generated the container with Dockerfile & environment.yml. This container was now pushed to quay.io/nf-core, therefore now retrieved by container 'nf-core/pipesidle:0.1.0-beta'.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b42e8f0

+| ✅ 190 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.9.0
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-02 12:55:46

@d4straub d4straub requested a review from maxulysse April 2, 2024 13:24
@d4straub
Copy link
Collaborator Author

d4straub commented Apr 2, 2024

Thanks a lot!

@d4straub d4straub merged commit 4707d38 into nf-core:dev Apr 2, 2024
17 checks passed
@d4straub d4straub deleted the pipesidle-container branch April 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4straub @maxulysse