-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema to use new definitions groups #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You have put tomorrow's data in the |
Yup - so this change will break the Launch functionality on the nf-core website. I still need to update that. I'm hoping to do that today, then maybe we can merge / deploy that tomorrow and do the releases at the same time? |
Cool. I am no rush so when you guys are happy and tested everything just let me know. |
Added new schema linting tests to check the schema title etc: nf-core/tools@66968f5 |
The CI test to push the new Docker image is being skipped here @ewels 🤔 Is this expected? Will the Docker image for the release be pushed to DockerHub automatically? Or is this something we have to factor in for |
Yeah, it only runs on chipseq/.github/workflows/ci.yml Line 101 in 048fd68
Should move this chunk into its own YAML file really, then it won't show up as being skipped. |
Preparing a minor patch-release to update the pipeline schema.
See nf-core/tools#696