Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema to use new definitions groups #171

Merged
merged 6 commits into from
Jul 29, 2020
Merged

Update schema to use new definitions groups #171

merged 6 commits into from
Jul 29, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Jul 28, 2020

Preparing a minor patch-release to update the pipeline schema.

See nf-core/tools#696

@ewels ewels requested a review from drpatelh July 28, 2020 08:36
nextflow_schema.json Outdated Show resolved Hide resolved
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drpatelh
Copy link
Member

You have put tomorrow's data in the CHANGELOG so happy to release both pipeline's tomorrow unless there is an urgency to get it out? Should I be waiting for you guys to be happy with the changes you are about to make to nf-core/tools? What I am asking is is this likely to change now? 😅

@ewels
Copy link
Member Author

ewels commented Jul 28, 2020

Yup - so this change will break the Launch functionality on the nf-core website. I still need to update that. I'm hoping to do that today, then maybe we can merge / deploy that tomorrow and do the releases at the same time?

@drpatelh
Copy link
Member

Cool. I am no rush so when you guys are happy and tested everything just let me know.

@ewels
Copy link
Member Author

ewels commented Jul 28, 2020

Added new schema linting tests to check the schema title etc: nf-core/tools@66968f5

@drpatelh
Copy link
Member

drpatelh commented Jul 28, 2020

The CI test to push the new Docker image is being skipped here @ewels 🤔 Is this expected? Will the Docker image for the release be pushed to DockerHub automatically? Or is this something we have to factor in for patch releases?

@ewels
Copy link
Member Author

ewels commented Jul 28, 2020

Yeah, it only runs on push or release, not pull-request:

if: ${{ github.repository == 'nf-core/chipseq' && (github.event_name == 'release' || github.event_name == 'push') }}

Should move this chunk into its own YAML file really, then it won't show up as being skipped.

@drpatelh drpatelh merged commit 0f487ed into master Jul 29, 2020
@ewels ewels deleted the patch branch July 29, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants