Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sample two lanes #225

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Add sample two lanes #225

merged 9 commits into from
Aug 7, 2024

Conversation

nschcolnicov
Copy link
Contributor

This PR addresses these two issues:

#182
#223

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nschcolnicov nschcolnicov requested a review from a team as a code owner August 5, 2024 20:24
@nschcolnicov nschcolnicov requested review from glichtenstein and removed request for a team August 5, 2024 20:24
@nschcolnicov
Copy link
Contributor Author

nschcolnicov commented Aug 5, 2024 •
edited
Loading

PR is on hold until the s3 bucket that contains the new dataset has its access fixed:
nf-core/ops#64

This PR was created from the add_kraken branch and should be merged after #220

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9ce19f7

+| ✅ 190 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   6 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-07 20:03:20

@edmundmiller edmundmiller mentioned this pull request Aug 7, 2024
Open
@edmundmiller
Copy link
Collaborator

Test data should be available now!

s5cmd --no-sign-request ls s3://nf-core-test-datasets/demultiplex/
2024/08/05 18:29:52         946339840  SingleCell-RNA_P3_2_short.tar.gz

@nschcolnicov nschcolnicov merged commit 7aee468 into nf-core:dev Aug 7, 2024
12 checks passed
@nschcolnicov nschcolnicov mentioned this pull request Aug 7, 2024
Closed
@apeltzer apeltzer mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@glichtenstein glichtenstein Awaiting requested review from glichtenstein glichtenstein is a code owner automatically assigned from nf-core/demultiplex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nschcolnicov @edmundmiller @apeltzer