-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new module: cellranger multi
#3229
Conversation
module test data PR: nf-core/test-datasets#848 |
update: after a lot of testing, it seems like my original design won't work
the problem is that the module process needs to stage all references (GEX, VDJ, etc.) as well as the FASTQs themselves, or else the Cellranger container cannot see them but staging won't happen if it is only fed the current design approach is
and then stage the references + FASTQs according to the config, with empty channels for unused references if need be |
linking to related efforts with Cumulus for reference |
the current paradigm is to write the config file before running the
this makes for a tidy module but unfortunately won't work from the Cellranger docs we see example configs with lines like
and instructions
as far as I can tell, this isn't bad until the config file is written in a different process than where Cellranger is run, since the working directories (and even the compute nodes themselves) need not be the same across both processes ergo it's probably wisest to build the config and run the downside here is that this omnibus process will need many arguments to account for all possible parametrizations of the config, something like this or maybe
the module will get long and ugly, but should hopefully still work |
…i' into add_cellranger_multi
good progress so far when creating config from within module itself, though the module code got ugly fast as a note of just how sensitive [error] Pipestance failed. Error log at:
test/SC_MULTI_CS/MULTI_PREFLIGHT_LOCAL/fork0/chnk0-u00134c48f4/_errors
Log message:
Your [vdj] reference does not contain the expected file (references/vdj/vdj_reference/fasta/regions.fa), or they are not readable. Please check your reference folder on 6f1571c9ccfa. the |
the process executes correctly but doesn't publish correctly the test chokes on the /private/var/folders/fy/gr30f0h12dz833zbd8_z5ls40000gn/T/pytest_workflow_8abz5ym2/cellranger_multi_test_cellranger_multi/work/45/702b77731e7de86bdb5864d58fbd22/.command.sh: line 87: warning: here-document at line 84 delimited by end-of-file (wanted `END_VERSIONS') a previous note suggests that multiline strings with newlines, such as whatever not sure how else to pass multiple sectioned options without parsing each potential option individually looks like we need another redesign 😣 |
it's been quite the odyssey but this module is now in a "working" state could subject this code to independent review now, but will first look for some extra test data currently, the only test configuration is GEX + VDJ the module needs tests with AB + BEAM + CRISPR + FB, if possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
PR checklist
Closes #2515
adds
cellranger multi
module, with concomitant modifications to othercellranger
code and test data as neededversions.yml
file.label
Use BioConda and BioContainers if possible to fulfil software requirements.only works with nfcore/cellranger Docker image