-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universc module update #3493
Universc module update #3493
Conversation
Changes: - No longer hides logs so Nextflow can actually see them - No longer relies on meta objects for parameters - No longer supports single file input (which did not work) - No longer adds containerOptions to the process - Splits the output parameters into separate channels
--reference ${reference_name} \\ | ||
--description ${sample_arg} \\ | ||
--id ${meta.id} \\ | ||
--read1 ${reads[0]} --read2 ${reads[1]} \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be on the next line
--read1 ${reads[0]} --read2 ${reads[1]} \\ | |
--read1 ${reads[0]} \\ | |
--read2 ${reads[1]} \\ |
|
||
# save log files | ||
echo !! > sample-${meta.id}/outs/_invocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What bash magic is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!
stands for the last executed command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need it? If someone wants to debug they can look into .command.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Trying to write around Nextflow is a major bugbear of mine.
"--per-cell-data", | ||
"--verbose", | ||
].join(" ").trim() | ||
} | ||
container = "nf-core/universc:1.2.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the container being set in here still?
container = "nf-core/universc:1.2.5.1" | ||
} | ||
|
||
withName: CELLRANGER_MKGTF { | ||
container = "nf-core/universc:1.2.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
container = "nf-core/universc:1.2.5.1" | ||
} | ||
|
||
withName: CELLRANGER_MKGTF { | ||
container = "nf-core/universc:1.2.5.1" | ||
} | ||
withName: CELLRANGER_MKREF{ | ||
container = "nf-core/universc:1.2.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
mkdir -p "${meta.id}/" | ||
mkdir -p "${meta.id}/SC_RNA_COUNTER_CS" | ||
mkdir -p "${meta.id}/journal" | ||
touch ${meta.id}/_log.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this log file still being made?
PR checklist
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware