Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanoplot and sequencing_summary.txt for Nanopore test data #364

Merged
merged 22 commits into from
Apr 9, 2021
Merged

Nanoplot and sequencing_summary.txt for Nanopore test data #364

merged 22 commits into from
Apr 9, 2021

Conversation

yuukiiwa
Copy link
Contributor

@yuukiiwa yuukiiwa commented Mar 24, 2021

Closes #287

grst
grst previously requested changes Mar 24, 2021
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yuukiiwa,

thanks for the PR!
Can you please

  • add a meta.yml file that describes all input and output data
  • Update the tests to use the new config file for test-data?

@yuukiiwa
Copy link
Contributor Author

Hi @grst, thanks for the comments! I have updated the branch using the test_data.config and added a meta.yml file for NanoPlot. The checks for docker and singularity pass now, but I am getting problems with conda on GitHub checks and also locally. Here is the error message I got from running PyTest with conda:
Screenshot 2021-03-25 at 11 27 27 AM

software/nanoplot/main.nf Outdated Show resolved Hide resolved
software/nanoplot/main.nf Outdated Show resolved Hide resolved
software/nanoplot/main.nf Outdated Show resolved Hide resolved
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @yuukiiwa ! Be nice to make the module more flexible to different types of input files. Don't worry about the failing Conda tests as long as the module is passing with Docker / Singularity.

@yuukiiwa
Copy link
Contributor Author

Hi @drpatelh, thank you for the comments! I will look into those!

@drpatelh drpatelh added the new module Adding a new module label Apr 8, 2021
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuukiiwa ! We should definitely add more tests for this even if it is to check that the other files exist. I have created a separate issue for this #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: nanoplot
3 participants