-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanoplot and sequencing_summary.txt for Nanopore test data #364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yuukiiwa,
thanks for the PR!
Can you please
- add a
meta.yml
file that describes all input and output data - Update the tests to use the new config file for test-data?
Hi @grst, thanks for the comments! I have updated the branch using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @yuukiiwa ! Be nice to make the module more flexible to different types of input files. Don't worry about the failing Conda tests as long as the module is passing with Docker / Singularity.
Hi @drpatelh, thank you for the comments! I will look into those! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #287