Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stringtie merge module (from nanoseq modules) #475

Merged
merged 8 commits into from
May 3, 2021

Conversation

yuukiiwa
Copy link
Contributor

No description provided.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!
Looks really good, except the two small things that I mentioned.

software/stringtie/merge/meta.yml Outdated Show resolved Hide resolved
software/stringtie/stringtie/functions.nf Outdated Show resolved Hide resolved
@yuukiiwa
Copy link
Contributor Author

Thanks for the comments, @KevinMenden! I will update you once I am done!

@yuukiiwa
Copy link
Contributor Author

yuukiiwa commented May 3, 2021

Hi @KevinMenden, thank you for your suggestions! I have addressed all of them!

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now! 👍

@KevinMenden KevinMenden merged commit 6ad50f8 into nf-core:master May 3, 2021
@yuukiiwa
Copy link
Contributor Author

yuukiiwa commented May 3, 2021

Thank you!!

mode: params.publish_dir_mode,
saveAs: { filename -> saveFiles(filename:filename, options:params.options, publish_dir:getSoftwareName(task.process), meta:meta, publish_by_meta:['']) }

// Note: 2.7X indices incompatible with AWS iGenomes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this line because this is only for STAR indices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants