Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend credits statement #41

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Amend credits statement #41

merged 1 commit into from
Apr 4, 2024

Conversation

FelixKrueger
Copy link
Contributor

Changed wording slightly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit adf1d10

+| ✅ 186 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗  10 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • schema_description - No description provided in schema for parameter: skip_ribotricer

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-04 16:40:34

pinin4fjords
pinin4fjords approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- there's some issue in the CI when there are no actual code changes- I'll try to fix

@FelixKrueger FelixKrueger merged commit 9f2403f into dev Apr 4, 2024
3 of 4 checks passed
@FelixKrueger FelixKrueger deleted the credits branch April 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FelixKrueger @pinin4fjords