Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legal logos and first metro map #54

Merged
merged 16 commits into from
Apr 16, 2024
Merged

Add legal logos and first metro map #54

merged 16 commits into from
Apr 16, 2024

Conversation

FelixKrueger
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/riboseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4f6fef9

+| ✅ 175 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.ribo_database_manifest
  • files_unchanged - File ignored due to lint config: assets/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-16 15:37:05

maxulysse
maxulysse reviewed Apr 16, 2024
View reviewed changes
docs/images/nf_core_riboseq_logo.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font is wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the viewbox is a bit too large

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think that? It is Maven Pro Bold, as requested

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I look at it from github, I don't see Maven Pro Bold

@JackCurragh
Copy link
Contributor

Looks like linting might be failing because the paths in 'files_unchanged' in .nf-core.yml don't point to valid files anymore. It should be as simple as renaming the files from nf-core_riboseq_logo_dark.png to nf-core-riboseq_logo_dark.png in docs/imagesor altering the paths in.nf-core.yml`

@pinin4fjords
Copy link
Member

Theres something weird with the hyphen in the logos

@FelixKrueger
Copy link
Contributor Author

Theres something weird with the hyphen in the logos

Something is weird with the display on Github, locally the files are fixed, and look perfectly fine. Maybe Github displays a cached copy?

dark:
Screenshot 2024-04-16 at 13 46 44

light:
Screenshot 2024-04-16 at 13 46 37

@FelixKrueger
Copy link
Contributor Author

OK found it, the light mode dark mode was accidentally inverted:
Screenshot 2024-04-16 at 13 54 14

I have changed this now, seems to work fine.

maxulysse
maxulysse reviewed Apr 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@FelixKrueger FelixKrueger merged commit f0f53fd into dev Apr 16, 2024
5 checks passed
@FelixKrueger FelixKrueger deleted the logos branch April 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FelixKrueger @JackCurragh @pinin4fjords @maxulysse