Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional UMI handling #73

Closed
ewels opened this issue Aug 20, 2018 · 8 comments
Closed

Add optional UMI handling #73

ewels opened this issue Aug 20, 2018 · 8 comments

Comments

@ewels
Copy link
Member

ewels commented Aug 20, 2018

From @ewels on August 21, 2017 8:46

It would be nice to add optional handling of UMIs, probably using this project: https://github.com/CGATOxford/UMI-tools

Copied from original issue: SciLifeLab#145

@ewels
Copy link
Member Author

ewels commented Aug 20, 2018

From @TomSmithCGAT on August 21, 2017 9:31

Hi @ewels - Let us know how you get on integrating UMI-tools into your pipeline. Very happy to help out via GitHub issues if you have any questions/issues etc

If you haven't already seen it, we have just released a quick scRNA-Seq tutorial: https://github.com/CGATOxford/UMI-tools/blob/master/doc/Single_cell_tutorial.md

@ewels
Copy link
Member Author

ewels commented Aug 20, 2018

Thanks @TomSmithCGAT! Yes I was just reading over it this morning. I particularly like the TL;DR; section at the top 😉

Whilst the single-cell / 10X analysis looks great, we're not currently running single cell projects in our facility so I think that we should probably keep things simple and just run umi_tools extract and umi_tools dedup if the pipeline is run with --bc-pattern. To be honest, my gut feeling is that single-cell data is different enough to warrant a totally separate pipeline anyway.

Phil

@ewels
Copy link
Member Author

ewels commented Aug 20, 2018

ps. How did you find this issue so quickly..??

@ewels
Copy link
Member Author

ewels commented Aug 20, 2018

From @TomSmithCGAT on August 21, 2017 10:8

Oh yeah, I'd assumed you were wanting to support UMIs for bulk RNA-Seq. Agree a separate pipeline is the best approach for scRNA-Seq.

I sporadically check who the new github stars are from (the speed was just by chance!). I saw you were at SciLife so I searched for "UMI-tools" in the organisation's github just to see what you were using UMI-tools for as we don't really have a very good idea what our user base actually is. We only really hear from people who have issues/questions etc - hopefully that's not everyone!

@ewels
Copy link
Member Author

ewels commented Aug 20, 2018

Aha, ok good to know - I was wondering if there was some magic notification service that I wasn't aware of 😉

@ewels
Copy link
Member Author

ewels commented Aug 20, 2018

From @TomSmithCGAT on August 21, 2017 13:17

No, that would be brilliant though!

@drpatelh
Copy link
Member

Can we close this issue now @grst due to the work you done in #435?

@grst
Copy link
Member

grst commented Aug 19, 2020

Yes, this is resolved. Too bad auto-close only works on the master branch...

@grst grst closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants