Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.8 #1016

Merged
merged 9 commits into from
May 9, 2023
Merged

Important! Template update for nf-core/tools v2.8 #1016

merged 9 commits into from
May 9, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.8 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.8 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/developers/sync.

For more information about this release of nf-core/tools, please see the v2.8 release page.

@github-actions
Copy link

github-actions bot commented May 6, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 252fd9d

+| ✅ 150 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreSchema.groovy
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-09 17:19:24

@drpatelh
Copy link
Member

drpatelh commented May 8, 2023

Linting expected to fail due to Remove quay.io prefix from mulled containers because module code will be outdated until nf-core/modules#3387 is merged. I will fix this in a follow up PR.

robsyme
robsyme reviewed May 8, 2023
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
robsyme
robsyme approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@robsyme robsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a little unclear about the status of mulled containers, but that might just be me. Otherwise lgtm

@drpatelh drpatelh merged commit 535360b into dev May 9, 2023
@drpatelh drpatelh deleted the nf-core-template-merge-2.8 branch November 21, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh left review comments

@robsyme robsyme robsyme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @drpatelh @robsyme