Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new testing strategy based on nf-test files #1253

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Add new testing strategy based on nf-test files #1253

merged 10 commits into from
Apr 9, 2024

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Mar 11, 2024 •
edited
Loading

Changes:

  • Workflow now parses repo for changed files with Python
  • Runs relevant tests by listing their nf-test files as the matrix of values
  • Uses tags to check for dependencies only

Related to:
nf-core/phageannotator#97
nf-core/fetchngs#300

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot
Add new testing strategy based on nf-test files
5b62627 
Changes:
 - Workflow now parses repo for changed files with Python
 - Runs relevant tests by listing their nf-test files as the matrix of values
 - Uses tags to check for dependencies only

Related to:
nf-core/phageannotator#97
nf-core/fetchngs#300
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f244455

+| ✅ 167 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • nextflow_config - Config default ignored: params.ribo_database_manifest
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-09 12:24:59

@adamrtalbot adamrtalbot marked this pull request as draft March 12, 2024 09:49
@drpatelh
Copy link
Member

This snippet should fix the linting with the actions_ci
https://github.com/nf-core/fetchngs/blob/8ec2d934f9301c818d961b1e4fdf7fc79610bdc5/.nf-core.yml#L2-L3

@adamrtalbot adamrtalbot marked this pull request as ready for review March 15, 2024 14:17
@adamrtalbot adamrtalbot added this to the nf-test milestone Apr 9, 2024
@adamrtalbot adamrtalbot merged commit 05c12ca into nf-core:dev Apr 9, 2024
184 checks passed
@adamrtalbot adamrtalbot deleted the new_testing_by_file_matrix branch April 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
nf-test
Development

Successfully merging this pull request may close these issues.
3 participants
@adamrtalbot @drpatelh @maxulysse