Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #432 + Formatting #436

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Fix #432 + Formatting #436

merged 5 commits into from
Jul 8, 2020

Conversation

grst
Copy link
Member

@grst grst commented Jul 7, 2020 •
edited by ewels
Loading

  • Adds the missing fastq channel for RSEM fc4d8f1
  • Formats main.nf in a more consistent manner (four spaces indent everywhere...)
  • Remove conflicting -k option from gunzip commands

PR checklist

  • PR is to dev rather than master
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

grst added 3 commits July 7, 2020 15:36
@grst
Fix nf-core#432
fc4d8f1
@grst
Update Changelog
13bf713
@grst
Format consistently
57e02e7 
Consistenly use 4-sepace indents along the file.
Exceedingly long lines were wrapped.
@grst grst changed the title Fix #432 Fix #432 + Formatting Jul 7, 2020
grst added 2 commits July 7, 2020 16:04
@grst
Fix gunzip compressed references
5ba6169 
The `-k` (keep) option is conflicting with `--stdout`.
When `--stdout` is used, the original file already
stays untouched.
@grst
Fix typo in changelog
12640f5
@grst grst requested review from apeltzer and a team July 7, 2020 14:31
@apeltzer apeltzer merged commit a278fb9 into nf-core:dev Jul 8, 2020
@apeltzer apeltzer mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grst @apeltzer