Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final polishing #164

Merged
merged 24 commits into from
Mar 27, 2020
Merged

Final polishing #164

merged 24 commits into from
Mar 27, 2020

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Mar 20, 2020

nf-core/sarek pull request

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse
Copy link
Member Author

Couldn't reproduce #118 so I'm currently giving up on trying to fix it, and going on with the release.

@maxulysse maxulysse requested a review from a team March 27, 2020 09:43
@maxulysse maxulysse added the enhancement New feature or request label Mar 27, 2020
@maxulysse maxulysse added this to the 2.6 milestone Mar 27, 2020
conf/test_split_fastq.config Outdated Show resolved Hide resolved
conf/test_targeted.config Outdated Show resolved Hide resolved
@ggabernet
Copy link
Member

Looks good to me, I just found two small things in the comments where I was not sure if it was intended or not

conf/test_targeted.config Outdated Show resolved Hide resolved
conf/test_targeted.config Outdated Show resolved Hide resolved
Co-Authored-By: Gisela Gabernet <gisela.gabernet@gmail.com>
@maxulysse maxulysse merged commit 5e7e65c into nf-core:dev Mar 27, 2020
@maxulysse maxulysse deleted the Mutect2 branch March 30, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants