Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --skip_markduplicates #205

Merged
merged 4 commits into from
May 18, 2020
Merged

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Just need to add some docs and sort out the mess I did, forgot to switch branches, so this one is base on my current PR regarding control-FREEC.
But as it's getting late, I'll finish tomorrow morning.

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added the enhancement New feature or request label May 12, 2020
@maxulysse maxulysse added this to the 2.6 milestone May 12, 2020
@maxulysse maxulysse marked this pull request as ready for review May 18, 2020 14:11
@maxulysse maxulysse requested a review from a team May 18, 2020 14:11
main.nf Show resolved Hide resolved
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

main.nf Show resolved Hide resolved
@maxulysse maxulysse merged commit f18ccf0 into nf-core:dev May 18, 2020
@maxulysse maxulysse deleted the skip_markDuplicates branch May 18, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants