Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting should check pipeline names for guidelines #85

Closed
apeltzer opened this issue Aug 8, 2018 · 4 comments
Closed

Linting should check pipeline names for guidelines #85

apeltzer opened this issue Aug 8, 2018 · 4 comments

Comments

@apeltzer
Copy link
Member

apeltzer commented Aug 8, 2018

qbic-pipelines/icgc-featurecounts#8

@maxulysse
Copy link
Member

Is the pipeline name following the lowercase convention an absolute requirement?

@ewels ewels added the linting label Aug 8, 2018
@apeltzer apeltzer added this to Medium difficulty in hackathon-scilifelab-2018 Aug 9, 2018
@ewels
Copy link
Member

ewels commented Oct 14, 2018

This becomes less important with new nf-core create name validation in #175 (but could still be nice and should be easy)

@apeltzer apeltzer added this to nf-core tools in hackathon-qbic-2019 Apr 2, 2019
@ewels
Copy link
Member

ewels commented Apr 2, 2019

Is the pipeline name following the lowercase convention an absolute requirement?

Up for discussion - the reason for this was that docker images are always lower case and without punctuation, so makes everything more consistent. Also just easier to remember if everything is always lower case.

NB: I remember way back thinking that the lint tool could be useful for people doing pipelines outside of nf-core (eg. forks). This test could be annoying there, so maybe good as a warning instead of a fail?

@apeltzer
Copy link
Member Author

apeltzer commented Apr 3, 2019

Yes, I think a warning is already sufficient, giving people feedback instead of just failing is better in such a case 👍

@ewels ewels added this to Beginner tasks in hackathon-scilifelab-2019 Dec 5, 2019
@FriederikeHanssen FriederikeHanssen self-assigned this Dec 5, 2019
This was referenced Dec 6, 2019
hackathon-scilifelab-2019 automation moved this from Beginner tasks to Done Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
hackathon-qbic-2019
  
nf-core tools
hackathon-scilifelab-2018
  
Medium difficulty
Development

No branches or pull requests

4 participants