Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added author to create command. Use prompts. #175

Merged
merged 11 commits into from
Nov 20, 2018
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Oct 5, 2018

  • Click command line flags now prompt for a response if required flags are not supplied when calling nf-core create
  • Author metadata now collected when creating a pipeline and inserted into template

Still need to finish the checklist:

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Click command line flags now prompt for a response if not supplied.
Author metadata collected when creating a pipeline.
@ewels ewels added the WIP Work in progress label Oct 5, 2018
@ewels ewels requested a review from a team October 5, 2018 22:06
@ewels ewels added template nf-core pipeline/component template command line tools Anything to do with the cli interfaces labels Oct 5, 2018
@ewels
Copy link
Member Author

ewels commented Oct 5, 2018

Let me know if anyone spots other locations in the template that should have author information!

@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #175 into dev will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #175      +/-   ##
==========================================
- Coverage   78.55%   78.46%   -0.09%     
==========================================
  Files           8        8              
  Lines         900      901       +1     
==========================================
  Hits          707      707              
- Misses        193      194       +1
Impacted Files Coverage Δ
nf_core/create.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc0f16...7a0546f. Read the comment docs.

@ewels ewels removed the WIP Work in progress label Oct 14, 2018
@ewels
Copy link
Member Author

ewels commented Oct 14, 2018

Ok, this is ready to merge now I think if everyone is happy.

@ewels
Copy link
Member Author

ewels commented Nov 20, 2018

Fixed merge conflicts again.. Good to merge now I think 😀

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@ewels ewels merged commit 2331c1e into nf-core:dev Nov 20, 2018
@ewels ewels deleted the create-prompt branch November 20, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces template nf-core pipeline/component template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants