Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline not following naming convention and logo missing #8

Closed
sven1103 opened this issue Aug 8, 2018 · 8 comments
Closed

Pipeline not following naming convention and logo missing #8

sven1103 opened this issue Aug 8, 2018 · 8 comments

Comments

@sven1103
Copy link

sven1103 commented Aug 8, 2018

no camelcase,
no hyphen,
all small letters.

for example: featurecountsicgc or featurecounts only?

@maxulysse
Copy link

I vote for featurecounts.
I think that in the long term it should work on more than ICGC

@maxulysse
Copy link

maxulysse commented Aug 8, 2018

Why not featurecountsonaws cf #7 ?

@sofiahag
Copy link

sofiahag commented Aug 8, 2018

same thing with EAGER2? :-)

@maxulysse
Copy link

And ViPR

@ewels
Copy link

ewels commented Aug 8, 2018

Yes - the reasoning for this is that simple lower case names will then be identical as dockerhub image (which has to have those constraints).

@maxulysse
Copy link

We could have a toLowerCase and strip - for Docker and just toLowerCase for Singularity.
But yes, I can see see why you would want such requirements.

@apeltzer
Copy link
Collaborator

apeltzer commented Aug 8, 2018

I think I’ll go for plain featurecounts and plain eager then - can make the intention of each pipeline clear in all cases anyways in the introduction and in the docs.

@apeltzer
Copy link
Collaborator

Logo is there, will still keep the nf-core one if thats ok?
I made it lowercase and kept the icgc, removed all profiles other than AWSBatch though to make clear this can only be used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants