Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch AssertionError from schema build #1267

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Catch AssertionError from schema build #1267

merged 4 commits into from
Nov 16, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Sep 7, 2021

Fixes bug found by @erikrikarddaniel where error from nextflow config raised an AssertionError that was not handled.

Untested.

Fixes bug found by @erikrikarddaniel where error from `nextflow config` raised an `AssertionError` that was not handled.
@github-actions

This comment has been minimized.

@ewels
Copy link
Member Author

ewels commented Sep 7, 2021

To replicate error, introduce a syntax error in nextflow.config etc. Without this fix you should get a big traceback. With the fix you should get a nicely formatted message that prints the nextflow error message.

@ewels
Copy link
Member Author

ewels commented Sep 7, 2021

Something fishy going wrong with the Black GitHub action - seems to be an installation error with Black, nothing related to the code change.

@ewels
Copy link
Member Author

ewels commented Sep 7, 2021

Hopefully this PR should fix the actions error: #1268

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1267 (a135b8e) into dev (f58077e) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1267      +/-   ##
==========================================
+ Coverage   67.52%   67.54%   +0.01%     
==========================================
  Files          50       50              
  Lines        5611     5611              
==========================================
+ Hits         3789     3790       +1     
+ Misses       1822     1821       -1     
Impacted Files Coverage Δ
nf_core/__main__.py 55.60% <0.00%> (ø)
nf_core/utils.py 84.50% <ø> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffab773...a135b8e. Read the comment docs.

@ewels
Copy link
Member Author

ewels commented Nov 16, 2021

Tested locally and seems to be working well ✅

@ewels ewels enabled auto-merge November 16, 2021 23:51
@ewels ewels disabled auto-merge November 16, 2021 23:54
@ewels ewels merged commit bc8e01c into dev Nov 16, 2021
@ewels ewels deleted the ewels-patch-1 branch November 16, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant