Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1294: Fixes to colors in Sphinx theme #1467

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

MatthiasZepper
Copy link
Member

@MatthiasZepper MatthiasZepper commented Mar 17, 2022

In order to address #1294, I have slightly modified the secondary colors of the light theme and added a few additional CSS selectors to ensure that there are no elements (like the hyperlinks) without associated styles. Those are styled with the default colors from the user's desktop theme and thus might not play well with the theme.

Secondary color change in light theme:

Orange to dark red: #f4a25b to #C03221
Lighter blue to darker blue: #6fb2e8 to #246EB9

Current light secondary color scheme:

colorsold

Proposed light secondary color scheme:

colorsnew

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thank you! 👍🏻

@ewels ewels merged commit a4944ff into nf-core:dev Mar 17, 2022
@MatthiasZepper MatthiasZepper deleted the issue1294_colors branch April 15, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants