Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/teams hook #1798

Merged
merged 11 commits into from
Sep 6, 2022
Merged

Feature/teams hook #1798

merged 11 commits into from
Sep 6, 2022

Conversation

matthdsm
Copy link
Contributor

@matthdsm matthdsm commented Sep 2, 2022

This PR adds a config option + function to enable messaging pipeline status updates through Teams

Examples:

Collapsed

Opened

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1798 (2fcb80e) into dev (433cc17) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1798   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          59       59           
  Lines        7148     7148           
=======================================
  Hits         4950     4950           
  Misses       2198     2198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthdsm
Copy link
Contributor Author

matthdsm commented Sep 2, 2022

I haven't updated the changelog yet since there're no new entry available

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! But maybe someone with more Groovy knowledge can have a better look 🙂

nf_core/pipeline-template/lib/NfcoreTemplate.groovy Outdated Show resolved Hide resolved
nf_core/pipeline-template/lib/NfcoreTemplate.groovy Outdated Show resolved Hide resolved
@matthdsm
Copy link
Contributor Author

matthdsm commented Sep 2, 2022

I'm aware there's a lot of duplicate code with the e-mail function, but I'm not really sure how I would go about cleaning that up in a "groovy" way.

@matthdsm
Copy link
Contributor Author

matthdsm commented Sep 2, 2022

Perhaps groovy master @mahesh-panchal would care to comment on the groovy part?

@mirpedrol
Copy link
Member

I'm aware there's a lot of duplicate code with the e-mail function, but I'm not really sure how I would go about cleaning that up in a "groovy" way.

I think the idea is to let Nextflow handle email (see #112), so it's probably not worth it to put a lot of effort into cleaning this.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking on that again. Let's merge it and test it on dev if you are happy with it 🙂
Remember to update the CHANGELOG before

@matthdsm
Copy link
Contributor Author

matthdsm commented Sep 6, 2022

Updated the changelog!

@mirpedrol
Copy link
Member

@nf-core-bot fix linting

@mirpedrol mirpedrol merged commit 07e4f38 into nf-core:dev Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants