-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended the hook_url functionality to Slack #1829
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1829 +/- ##
=======================================
Coverage 63.74% 63.74%
=======================================
Files 41 41
Lines 4913 4913
=======================================
Hits 3132 3132
Misses 1781 1781 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Love it, just left one small comment |
|
Is this considered to be superseded by https://github.com/Midnighter/nf-slack ? |
23d0d19
to
33a09af
Compare
Thank you ! |
Please add documentation about this nf-core/website#1455 |
Hello,
Got very interested in what @matthdsm did in #1798 . This is a small extension to support Slack as well, since Slack doesn't understand adaptive cards.
Here is how the notifications look like:
The JSON has a very long and tricky line where I try to improve the look-and-feel of the pipeline configuration:
Note: I am using the legacy "attachments" method of the Slack API, rather than the now-recommended Block Kit method, because I couldn't find how to make the latter put some colour. I think one has to immediately know whether it failed or not, and the colour is faster to recognise than the text itself.
PR checklist
CHANGELOG.md
is updateddocs
is updated