Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module import #579

Merged
merged 5 commits into from
Jun 2, 2020
Merged

Module import #579

merged 5 commits into from
Jun 2, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 3, 2020

Proof-of-concept pull request for building a simplistic import system tools from nf-core/modules into pipelines.

See nf-core/modules#8 for (extensive) discussion.

Current functionality:

$ nf-core modules --help


                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

Usage: nf-core modules [OPTIONS] COMMAND [ARGS]...

  Manage DSL 2 module imports

Options:
  --help  Show this message and exit.

Commands:
  list     List available tools
  install  Install a DSL2 module
  update   Update one or all DSL2 modules
  remove   Remove a DSL2 module
  check    Check that imported module code has not been modified
  fix      Replace imported module code with a freshly downloaded copy
$ nf-core modules list

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'


INFO: Tools available from nf-core/modules:

bwa
fastqc
gatk
htslib
samtools
trim_galore
$  nf-core modules install fastqc

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

$ ls modules/tools/fastqc/
main.nf   meta.yml  test/

Made proper start on nf-core modules install. Now gets details from GitHub and downloads tool files.
@ewels ewels added the WIP Work in progress label Mar 3, 2020
@ewels ewels changed the base branch from dev to module-import June 2, 2020 15:52
@ewels
Copy link
Member Author

ewels commented Jun 2, 2020

Merging into module-import branch so that others can work on the code..

@ewels ewels marked this pull request as ready for review June 2, 2020 15:52
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #579 into module-import will decrease coverage by 2.66%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           module-import     #579      +/-   ##
=================================================
- Coverage          66.55%   63.89%   -2.67%     
=================================================
  Files                 11       12       +1     
  Lines               1848     1925      +77     
=================================================
  Hits                1230     1230              
- Misses               618      695      +77     
Impacted Files Coverage Δ
nf_core/modules.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b91ace...f97d5dc. Read the comment docs.

@ewels ewels merged commit 4554437 into nf-core:module-import Jun 2, 2020
@ewels ewels mentioned this pull request Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant