Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10.2 patch #713

Merged
merged 8 commits into from
Jul 31, 2020
Merged

1.10.2 patch #713

merged 8 commits into from
Jul 31, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Jul 30, 2020

PR to dev for 1.10.2 patch release. See milestone: https://github.com/nf-core/tools/milestone/9

Extra stuff from nf-core/chipseq#177 template merge

Stretch goal:

@ewels ewels added the WIP Work in progress label Jul 30, 2020
@ewels ewels self-assigned this Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #713 into dev will decrease coverage by 0.05%.
The diff coverage is 68.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #713      +/-   ##
==========================================
- Coverage   81.98%   81.92%   -0.06%     
==========================================
  Files          13       13              
  Lines        2753     2766      +13     
==========================================
+ Hits         2257     2266       +9     
- Misses        496      500       +4     
Impacted Files Coverage Δ
nf_core/sync.py 62.87% <0.00%> (+0.30%) ⬆️
nf_core/lint.py 91.27% <77.41%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7debe...b72b94f. Read the comment docs.

@ewels ewels marked this pull request as ready for review July 30, 2020 23:11
@ewels ewels mentioned this pull request Jul 30, 2020
4 tasks
@ewels ewels added this to the 1.10.2 patch milestone Jul 30, 2020
@ewels ewels marked this pull request as draft July 31, 2020 06:55
@ewels ewels marked this pull request as ready for review July 31, 2020 06:56
@ewels ewels removed the WIP Work in progress label Jul 31, 2020
@ewels
Copy link
Member Author

ewels commented Jul 31, 2020

I will handle the sync stuff in a separate PR

Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ggabernet ggabernet merged commit 16f92ef into nf-core:dev Jul 31, 2020
@ewels ewels deleted the 1.10.2-patch branch July 31, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants