Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split steps create lint wf #941

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 22, 2021

  • Split up CI commands into separate steps for create-lint-wf to make it easier to read
  • Added automated PR comments for markdown + Python code linting CI

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #941 (c9a3b11) into dev (1c0291e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #941      +/-   ##
==========================================
+ Coverage   69.56%   69.59%   +0.02%     
==========================================
  Files          34       34              
  Lines        4173     4173              
==========================================
+ Hits         2903     2904       +1     
+ Misses       1270     1269       -1     
Impacted Files Coverage Δ
nf_core/__main__.py 61.58% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0291e...c9a3b11. Read the comment docs.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like those comments about Black 👍

@ewels
Copy link
Member Author

ewels commented Mar 22, 2021

Would be good to test them on dev before release to be sure that I haven't messed up the formatting etc - quite easy to do.

@ewels ewels merged commit c51f8f0 into nf-core:dev Mar 22, 2021
@ewels ewels deleted the split-steps-create-lint-wf branch March 22, 2021 20:14
@ewels
Copy link
Member Author

ewels commented Mar 22, 2021

..to clarify, I mostly mean that because if they work I would like to add them to the pipeline template too 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants