Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#9): Add prettier-vscode #10

Merged
merged 7 commits into from
Mar 23, 2022
Merged

feat(#9): Add prettier-vscode #10

merged 7 commits into from
Mar 23, 2022

Conversation

edmundmiller
Copy link
Collaborator

Merge when nf-core/tools#1457 is ready

@edmundmiller edmundmiller requested a review from ewels March 17, 2022 15:30
@edmundmiller edmundmiller self-assigned this Mar 17, 2022
@mashehu
Copy link

mashehu commented Mar 17, 2022

Please don't forget to add it to the gitpod.yml in the nf-co.re repo (if it available in that extension marketplace)

@edmundmiller
Copy link
Collaborator Author

edmundmiller commented Mar 17, 2022 •
edited
Loading

Good catch! I'm adding it in the dependancies.

@mashehu
Copy link

mashehu commented Mar 17, 2022

sorry, looked it up, it is already in the nf-co.re repo gitpod.yml, but not in the tools gitpod.yml including the template.

mashehu
mashehu requested changes Mar 17, 2022
View reviewed changes
Copy link

@mashehu mashehu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we list all of them also in the readme of this repo, so please mention prettier also there

@edmundmiller edmundmiller merged commit ab57b4b into master Mar 23, 2022
@edmundmiller edmundmiller deleted the prettier branch March 23, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@ewels ewels Awaiting requested review from ewels

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundmiller @mashehu