add crypto token #24
Merged
add crypto token #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarsiBarsi
approved these changes
Jul 8, 2021
Contributor
MarsiBarsi
left a comment
MarsiBarsi
left a comment
There was a problem hiding this comment.
Hey! Thanks for your contribution :)
waterplea
requested changes
Jul 8, 2021
Member
waterplea
left a comment
waterplea
left a comment
There was a problem hiding this comment.
Looks like checks are not running for external contributions. We'll fix that, in the meantime please check my comment 😉
projects/common/src/tokens/crypto.ts
Outdated
| export const CRYPTO = new InjectionToken<Crypto>( | ||
| 'An abstraction over window.crypto object', | ||
| { | ||
| factory: () => inject(WINDOW).localStorage, |
Contributor
Author
There was a problem hiding this comment.
Woops, indeed. copy/pasted too quickly :)
Contributor
Author
There was a problem hiding this comment.
Not sure of github sends notifications for force-pushes. Updated, though.
waterplea
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This PR introduces a token for the Web Crypto API
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information