Deal with networks (supports new overlay network) #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This file is just an example. Were you intending to fix this issue w/ |
|
I send PR on But I think that fix template example right now will limit the feedback, because the new model network will be activate systematically in the |
jwilder
added a commit
that referenced
this pull request
Jan 26, 2016
Deal with networks (supports new overlay network)
|
Thanks @baptistedonaux! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial template works with current model network.
If you use the new overlay network (ex. docker-compose --x-networking up), the golang structure RuntimeContainer -> []Address doesn't contain IP (empty string).
Use []Network array resolved the problem.