remove validation checks for spec changes

Author: salonichf5

internal/controller/nginx/config/policies/upstreamsettings/validator.go

@@ -107,13 +107,6 @@ func (v Validator) validateSettings(spec ngfAPI.UpstreamSettingsPolicySpec) erro
 		allErrs = append(allErrs, v.validateUpstreamKeepAlive(*spec.KeepAlive, fieldPath.Child("keepAlive"))...)
 	}
 
-	if spec.LoadBalancingMethod != nil {
-		allErrs = append(
-			allErrs,
-			v.validateLoadBalancingMethod(*spec.LoadBalancingMethod, fieldPath.Child("loadBalancingMethod"))...,
-		)
-	}
-
 	return allErrs.ToAggregate()
 }
 
@@ -141,25 +134,3 @@ func (v Validator) validateUpstreamKeepAlive(
 
 	return allErrs
 }
-
-func (v Validator) validateLoadBalancingMethod(
-	method ngfAPI.LoadBalancingType,
-	fieldPath *field.Path,
-) field.ErrorList {
-	var allErrs field.ErrorList
-
-	switch method {
-	case ngfAPI.LoadBalancingTypeIPHash, ngfAPI.LoadBalancingTypeRandomTwoLeastConnection:
-	default:
-		allErrs = append(allErrs, field.NotSupported(
-			fieldPath,
-			method,
-			[]string{
-				string(ngfAPI.LoadBalancingTypeIPHash),
-				string(ngfAPI.LoadBalancingTypeRandomTwoLeastConnection),
-			},
-		))
-	}
-
-	return allErrs
-}

internal/controller/nginx/config/policies/upstreamsettings/validator_test.go

@@ -118,17 +118,6 @@ func TestValidator_Validate(t *testing.T) {
 						"'must contain an, at most, four digit number followed by 'ms', 's', 'm', or 'h'')]"),
 			},
 		},
-		{
-			name: "invalid load balancing method",
-			policy: createModifiedPolicy(func(p *ngfAPI.UpstreamSettingsPolicy) *ngfAPI.UpstreamSettingsPolicy {
-				p.Spec.LoadBalancingMethod = helpers.GetPointer[ngfAPI.LoadBalancingType]("invalid-lb-method")
-				return p
-			}),
-			expConditions: []conditions.Condition{
-				conditions.NewPolicyInvalid("spec.loadBalancingMethod: Unsupported value: \"invalid-lb-method\": " +
-					"supported values: \"ip_hash\", \"random two least_conn\""),
-			},
-		},
 		{
 			name:          "valid",
 			policy:        createValidPolicy(),