-
Notifications
You must be signed in to change notification settings - Fork 137
Add workflow to validate UBI images pass RedHat Certification #4035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
==========================================
- Coverage 86.83% 86.80% -0.04%
==========================================
Files 128 128
Lines 16607 16607
Branches 62 62
==========================================
- Hits 14421 14415 -6
- Misses 2004 2009 +5
- Partials 182 183 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/workflows/ci.yml
Outdated
openshift-certification: | ||
name: OpenShift Certification | ||
needs: [build-oss, build-plus, build-operator] | ||
if: ${{ inputs.dry_run || false }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this isn't pushing anything don't need the dry run condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, it also doesn't need to run on every build - maybe only on merges to main and releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Just while testing, I'm going to have it run on pull requests as well for this PR.
So it will look like this:
openshift-certification:
name: OpenShift Certification
needs: [build-oss, build-plus, build-operator]
if: >
${{ github.event_name == 'pull_request'
&& github.event.pull_request.base.ref == 'main'
|| (github.event_name == 'push' && github.ref == 'refs/heads/main')
|| (inputs.is_production_release == true)
}}
uses: ./.github/workflows/openshift-certification.yml
with:
runner: ubuntu-24.04
permissions:
contents: read
packages: read
secrets: inherit
- name: Run preflight for NGINX Gateway Fabric | ||
env: | ||
PYXIS_API_TOKEN: ${{ secrets.PYXIS_API_TOKEN }} | ||
run: preflight check container ghcr.io/nginx/nginx-gateway-fabric:edge-ubi --json > ngf-preflight-result.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the images being tested reflect what was built in this run instead of hardcoding to edge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I added these more to test the pipeline in general. I'll make sure those get updated
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Proposed changes
This change adds a new workflow file,
openshift-certification.yml
which is responsible for validating that our UBI based images of NGF, NGINX OSS, and NGF Operator will pass the RedHad certification process.This workflow uses RedHat Openshift Preflight tool to pre-certify images before they are published:
https://github.com/redhat-openshift-ecosystem/openshift-preflight
Closes #3909
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.