Object.getOwnPropertyDescriptor() should not query an object's prototype chain

[drsm]

>> var p = Object.create(null);
undefined
>> p.one = 1;
1
>> 'one' in p
true
>> var o = Object.create(p);
undefined
>> 'one' in o
true
>> JSON.stringify(Object.getOwnPropertyDescriptor(p, 'one'));
{"value":1,"configurable":true,"enumerable":true,"writable":true}
>> JSON.stringify(Object.getOwnPropertyDescriptor(o, 'one'));
{"value":1,"configurable":true,"enumerable":true,"writable":true}

[xeioex]

Hi @drsm,

Please, take a look at the following patch. Here, I did some refactor of internal primitives to make them more in line with methods from the spec like [[Get]], [[GetProperty]], [[GetOwnProperty]] etc.
It is expected to fix #32 and #34.

https://gist.github.com/xeioex/4d3526c4128560559fb3d1c73e08356f

[drsm]

Hi @xeioex!

I did tests against the patch from #9.
GetOwnProperty stuff works as expected now.
#34 is fixed too.

there is still some issues with prototype chain lookup & exotic objects, maybe unrelated:

>> var s = Object.create(new String('asdf'));
undefined
>> s[0]
undefined
>> s.length
0
>> s.hasOwnProperty('length')
true
>> Object.getOwnPropertyDescriptor(s,'length')
{
 value: 0,
 configurable: false,
 enumerable: false,
 writable: false
}
>> var a = Object.create([1,2,3]);
undefined
>> a[0]
undefined
>> a.length
0
>> a.hasOwnProperty('length')
true
>> Object.getOwnPropertyDescriptor(a,'length')
{
 value: 0,
 configurable: false,
 enumerable: false,
 writable: true
}

[xeioex]

Hi @drsm,

Thank you for the testing.
I will deal with the prototype chain lookup issue.

[xeioex]

@drsm By the way, the njs CLI is now available in the official docker container

docker run -i -t nginx:latest /usr/bin/njs

https://github.com/xeioex/njs-examples