Rethinking exit hook. #970
Merged
+128
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeioex
force-pushed
the
rethinking_exit_hook
branch
from
e9a2a11 to
f54c05f
Compare
This was referenced Sep 30, 2025
xeioex
force-pushed
the
rethinking_exit_hook
branch
from
f54c05f to
be3b55b
Compare
The issue was introduced in commit 04f6dfb (0.9.2) by moving VM destruction from the pool cleanup handler to the http cleanup handler. Moving VM destruction to the http cleanup handler broke js_set variable usage during the log phase, because these variables are called after the VM has been destroyed. The fix is to move VM destruction back to the pool cleanup handler, but use a temporary pool while njs.on('exit', ...) is executing. This fixes nginx#969 and nginx#971 issues on Github.
xeioex
force-pushed
the
rethinking_exit_hook
branch
from
be3b55b to
4936209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.