Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kingman merge #54

Merged
merged 21 commits into from
Apr 18, 2024
Merged

Kingman merge #54

merged 21 commits into from
Apr 18, 2024

Conversation

ThomUK
Copy link
Collaborator

@ThomUK ThomUK commented Apr 16, 2024

This is the PR to merge Neil's recent work from the kingman branch into main.
The main changes are:

  1. A re-working of the target_capacity() function, to remove the 'F' parameter, and replace with other coefficients of variation.
  2. Addition of a suite of wl_*() functions to handle waiting lists and generate stats from them

neilwalton and others added 21 commits January 17, 2024 08:34
@neilwalton
waiting list functions added
3b0cc1e
working on wl_stats
27d9216
@neilwalton
various vignette fixes
8b88a6f
@neilwalton
add dplyr package
adae183
@neilwalton
relief cap added to wl_stats
5eb56c1
@neilwalton
referral and removal stats files added
86724d8
@ThomUK
Merge branch 'kingman' into kingman_merge_test
a712201
@ThomUK
update package to use latest orxygen version
81b9242
@ThomUK
re-create documentation
3f96b77
@ThomUK
add missing param descriptions and re-document
eb4a352
@ThomUK
update failing test by adding new args and updating results
5c7542f
@ThomUK
update vignette to use new argument name
e2b6b7f
@ThomUK
add formal dplyr dependency and remove library call
4561008
@ThomUK
remove some illegal characters from roxygen examples and re-run docum…
4bce4b7 
…entation
@ThomUK
minor fixes to roxygen examples prompted by CMD check
7219018
@ThomUK
update params and examples
df85a6b
@ThomUK
regenerate documentation
12d3035
@ThomUK
run styler::style_pkg()
3c6e206
@ThomUK
appeasing the line length linter
af935dd
@ThomUK
disable lint errors for commented code
188bea6
@ThomUK
fix all linting errors
a89f64f
@ThomUK ThomUK marked this pull request as ready for review April 17, 2024 19:03
@ThomUK ThomUK requested a review from chrismainey April 17, 2024 19:04
@ThomUK ThomUK mentioned this pull request Apr 17, 2024
Closed
chrismainey
chrismainey approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@chrismainey chrismainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable to me. Not tested anything in detail, unit tests pass and @ThomUK has reviewed. Happy to merge.

@chrismainey chrismainey merged commit 4038ef2 into main Apr 18, 2024
8 checks passed
@chrismainey chrismainey deleted the kingman_merge branch April 18, 2024 16:20
@ThomUK ThomUK mentioned this pull request May 1, 2024
Closed
@ThomUK ThomUK mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismainey chrismainey chrismainey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomUK @chrismainey @neilwalton