Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made changes in method.mapping.js of issue#4028 #4163

Closed
wants to merge 1 commit into from

Conversation

Ashu463
Copy link

@Ashu463 Ashu463 commented Mar 31, 2024

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • [ ✔] Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • [ ✔] Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • [ ✔] If you're fixing a bug also create an issue if one doesn't exist yet;
  • [ ✔] If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • [ ✔] Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • [ ✔] If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • [ ✔] Do not include changes that are not related to the issue at hand;
  • [ ✔] Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • [ ✔] Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2024

CLA assistant check
All committers have signed the CLA.

@Ashu463
Copy link
Author

Ashu463 commented Mar 31, 2024

Hey @garg3133 I had made changes according to procedure you mentioned in the issue description so pls review it

@garg3133
Copy link
Member

Not sure what the author aims to achieve here but whatever it is the implementation makes no sense.

@garg3133 garg3133 closed this Apr 17, 2024
@Ashu463
Copy link
Author

Ashu463 commented Apr 19, 2024

I just followed the steps which are mentioned without understanding what it wants to do, so really apologize for it, will ensure to handle issues after understanding it properly
Thnks for having a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants