Using T_INLINE_HTML php constant implications between minor php versions

[macropay-solutions]

You don't have a discussions tab so, we have to create an issue for this note:

T_INLINE_HTML changes with almost every minor php release. This info comes from here php/php-src#18067 (comment)

How did we get to this you can see in this thread: laravel/framework#52382 (reply in thread)

Taking into account that you define a class constant with the same name in your library, please make sure you are not affected by this behavior.

[nikic]

The constant defined by the parser don't rely on having the same value as the constants defined by PHP. You can find the logic for mapping between the values here:

PHP-Parser/lib/PhpParser/ParserAbstract.php

Lines 1245 to 1285 in c9d0b6c

	/**
	* Creates the token map.
	*
	* The token map maps the PHP internal token identifiers
	* to the identifiers used by the Parser. Additionally it
	* maps T_OPEN_TAG_WITH_ECHO to T_ECHO and T_CLOSE_TAG to ';'.
	*
	* @return array<int, int> The token map
	*/
	protected function createTokenMap(): array {
	$tokenMap = [];
	// Single-char tokens use an identity mapping.
	for ($i = 0; $i < 256; ++$i) {
	$tokenMap[$i] = $i;
	}
	foreach ($this->symbolToName as $name) {
	if ($name[0] === 'T') {
	$tokenMap[\constant($name)] = constant(static::class . '::' . $name);
	}
	}
	// T_OPEN_TAG_WITH_ECHO with dropped T_OPEN_TAG results in T_ECHO
	$tokenMap[\T_OPEN_TAG_WITH_ECHO] = static::T_ECHO;
	// T_CLOSE_TAG is equivalent to ';'
	$tokenMap[\T_CLOSE_TAG] = ord(';');
	// We have created a map from PHP token IDs to external symbol IDs.
	// Now map them to the internal symbol ID.
	$fullTokenMap = [];
	foreach ($tokenMap as $phpToken => $extSymbol) {
	$intSymbol = $this->tokenToSymbol[$extSymbol];
	if ($intSymbol === $this->invalidSymbol) {
	continue;
	}
	$fullTokenMap[$phpToken] = $intSymbol;
	}
	return $fullTokenMap;
	}

See also https://github.com/nikic/PHP-Parser/blob/master/lib/PhpParser/compatibility_tokens.php for the logic to define compatibility tokens that are only present in new PHP versions.

[macropay-solutions]

Ok. It was just a heads up for you. Thank you.
Other constants fall under the same scope.

[macropay-solutions]

See also https://github.com/nikic/PHP-Parser/blob/master/lib/PhpParser/compatibility_tokens.php for the logic to define compatibility tokens that are only present in new PHP versions.

The issue is the tokens are changing in value from minor version to minor version.
So, if you rely on their value, you will have issues.

If you use your class constants in a separate logic from the php default ones, than it should be ok.

[macropay-solutions]

@nikic also you might mention this issue in your readme that NON DOCKER deployments can be affected by rolling deploys of minor php versions.

You can follow also that thread in laravel discussions to see the end result.

Thank you again.