Repository navigation
What's Changed
This is a security release on the 3.2.4 line. It fixes five weaknesses in the handling of items. A change proposal, still accepted through a crafted request although the Items page no longer offers the form, overwrote the encryption keys of an unrelated item and made its password unrecoverable. Four other actions checked that the caller could open the item's folder, but not the item's own restrictions or the caller's rights on it: the automatic password update frequency, sharing an item by email, subscribing to an item's change notifications and adding a manual history entry. Through them, a folder member excluded from an item, a read-only member or, for the update frequency, any signed-in user could change an item's settings, learn its label and folder path, or write backdated entries into its history. Four of these were reported by Aditay Kumar (@adityasunny06help-coder), one of them also by @benchmeister. Upgrading is recommended for all installations.
This release is code only: no ALTER TABLE, no schema change and no new data migration. UPGRADE_MIN_DATE is deliberately left at its 3.2.4.4 value, so installations already running 3.2.4.4 are not sent back through the upgrade wizard.
Installations that ever used change proposals should check their items. Proposals damaged items before this release, including the ones made through the Items page form when it still existed, up to 3.1.1. See Upgrade notes for how to find the affected items.
🔒 Security fixes
- Change proposals no longer destroy the encryption keys of an unrelated item (GHSA-xp38-wccv-8v49) — the change proposal action stored the proposal's key in the item key table under the proposal's own row id. Proposal ids and item ids are two independent sequences, so each proposal replaced or blanked every user's key on the item that happened to carry the same id, the server's recovery account included. That item's password could no longer be decrypted by anyone, and repairing the keys cannot bring it back. Any signed-in user who could open a folder could repeat the request and reach items 1, 2, 3 and so on, in every folder, personal folders included. The Items page has not offered the proposal form since 3.1.2, and the proposed values were never read back, so the action is removed. Installations running 3.0.0.0 or later are affected.
- Manual history entries require edit rights on the item (GHSA-4hrh-wjp5-wrph, reported by Aditay Kumar, @adityasunny06help-coder) — adding an entry to an item's history checked folder access and the user list of the item's restriction, but not its role restriction or the caller's rights. A folder member excluded from the item through a role, a read-only member or an administrator could write entries with any date into its audit history. The Manual insertions in item history log allowed setting was checked by the page only, not by the server. The server now checks that setting, refuses a deleted item and requires the same edit right as saving the item. The answer also returned the item's latest history entry, whoever had written it: it no longer does. Installations running 3.0.0.0 or later are affected.
- Changing an item's automatic password update frequency requires edit rights on it (GHSA-ccc7-vc5r-qp79, reported by @benchmeister and by Aditay Kumar, @adityasunny06help-coder) — the action changed the frequency of the item whose id was posted, for any signed-in user, without checking any right on it. It now requires Enable changing password on distant server to be on, a live item the caller may edit, and one of the frequencies the form offers. Checking the rights does not take the item's edit lock. Installations running 3.0.0.0 or later are affected.
- Sharing an item by email respects the item's restrictions (GHSA-6qg7-w2p8-7rw4, reported by Aditay Kumar, @adityasunny06help-coder) — the share action only checked that the caller could open the item's folder. A member of that folder excluded from the item, by user or by role, could send its label, folder path and link to any address. It now requires read access to a live item. A second email action, unused by any page and without any access check, could send the label and folder path of any item to a chosen user: it is removed, together with its Access request to an item email template. Installations running 3.0.0.0 or later are affected.
- Change notifications respect the item's restrictions (GHSA-9375-g3m3-9jvg, reported by Aditay Kumar, @adityasunny06help-coder) — subscribing to an item's change notifications only checked folder access, so a member excluded from the item could subscribe and receive by email its label, folder and the author of every change. Subscribing now requires read access to a live item. Each notification also checks every subscriber's current read access before sending, so a subscription taken earlier, or before a restriction or role change, stops receiving emails. Passwords were never part of these emails. Installations running 3.0.0.0 or later are affected.
⬆️ Upgrade notes
- Schema. No schema change. Installations already running 3.2.4.4 deploy the new files and are not sent through the upgrade wizard.
- Items damaged by change proposals. Each proposal damaged the item whose id equals the proposal's id.
SELECT id FROM teampass_items_change(replaceteampass_with your table prefix) lists the ids of the items hit by the proposals still stored. Purging an item also deletes its proposals, so the list can be incomplete: the table'sAUTO_INCREMENTvalue minus one gives the highest item id that may have been hit. For each of those items, check that its password still opens. If it does not, restore it from a backup taken before the damage, or have it entered again. The upgrade leaves theitems_changerows in place. - Change notifications. Existing subscriptions are kept. A subscriber who can no longer read an item stops receiving its notifications, and receives them again if access is granted back.
- Manual history entries. They now need Manual insertions in item history log allowed on the server side as well, and edit rights on the item. Read-only members and administrators can no longer add them.
- Automatic password update frequency. It can be changed only while Enable changing password on distant server is on, which is already the only case where the item form shows it.
- Email templates. Access request to an item is no longer listed in Configuration → Email templates, because nothing sends that email any more. A customization saved for it stays in the database, unused.
- Back up your database before upgrading, as always.
Full Changelog: 3.2.4.4...3.2.4.5
Important
- Requires at least
PHP 8.2
Languages
Please join Teampass v3 translation project on Poeditor and translate it for your language.
Installation
Follow instructions from Documentation.
Upgrade
Follow instructions from Documentation.
Ideas and comments
Are welcome ... please use Discussions.
Help others find TeamPass
If TeamPass serves your team well, a ⭐ on this repository, a like on AlternativeTo or a short review on SourceForge helps other administrators find it.