WIP: Drafts of governance, roadmap #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci]
Still need more on BIAP process.
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
==========================================
+ Coverage 92.20% 92.25% +0.04%
==========================================
Files 100 100
Lines 12139 12185 +46
Branches 2121 2132 +11
==========================================
+ Hits 11193 11241 +48
+ Misses 618 616 -2
Partials 328 328
Continue to review full report at Codecov.
|
effigies
reviewed
May 12, 2021
Comment on lines
+71
to
+72
| The Steering Council (SC) members are core developers who have additional | ||
| responsibilities to ensure the smooth running of the project. SC members are |
There was a problem hiding this comment.
Suggested change
| The Steering Council (SC) members are core developers who have additional | |
| responsibilities to ensure the smooth running of the project. SC members are | |
| The Steering Council (SC) members are current or former core developers who | |
| have additional responsibilities to ensure the smooth running of the project. | |
| SC members are |
effigies
reviewed
May 12, 2021
doc/source/devel/governance.rst
Outdated
Comment on lines
120
to
122
| - **Code changes and major documentation changes** require agreement by *two* | ||
| core developers *and* no disagreement or requested changes by a core | ||
| developer on the issue or pull-request page (lazy consensus). |
There was a problem hiding this comment.
A requirement for two reviewers is a high bar for nibabel, historically. Maybe something like:
Suggested change
| - **Code changes and major documentation changes** require agreement by *two* | |
| core developers *and* no disagreement or requested changes by a core | |
| developer on the issue or pull-request page (lazy consensus). | |
| - **Code changes and major documentation changes** require approval by *two* | |
| reviewers, including at least one core developer, *and* no disagreement or | |
| requested changes by a core developer on the issue or pull-request page | |
| (lazy consensus). If a core developer calls for a second review, they may | |
| merge after a "reasonable" interval. |
There was a problem hiding this comment.
I changed the two to "one" in the modified version. Is that OK?
We don't have enough developers to require two to review.
|
@matthew-brett I'm going to merge to get a rendered version up. I suspect we'll only need small touchups after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ready to submit for NumFocus membership.