Skip to content

FIX: Return error codes in dicomfs, rather than raise #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Aug 22, 2021

Illegal raise

Illegal class 'int' raised; will result in a TypeError being raised instead.

I believe the intent was to return, not to raise. @chrispycheng Can you confirm?

Illegal class 'int' raised; will result in a TypeError being raised instead.
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1048 (497b189) into master (75af371) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1048   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         100      100           
  Lines       12205    12205           
  Branches     2136     2136           
=======================================
  Hits        11261    11261           
  Misses        616      616           
  Partials      328      328           
Impacted Files Coverage Δ
nibabel/cmdline/dicomfs.py 18.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75af371...497b189. Read the comment docs.

@chrispycheng
Copy link
Contributor

@DimitriPapadopoulos you got it! nice catch, thanks.

@effigies effigies changed the title FIX: LGTM error FIX: Return error codes in dicomfs, rather than raise Sep 8, 2021
@effigies
Copy link
Member

effigies commented Sep 8, 2021

Thanks! Test failures are unrelated.

@effigies effigies merged commit 1a76e34 into nipy:master Sep 8, 2021
@DimitriPapadopoulos DimitriPapadopoulos deleted the lgtm_illegal_raise branch September 8, 2021 14:26
effigies pushed a commit that referenced this pull request Feb 7, 2022
Illegal class 'int' raised; will result in a TypeError being raised instead.

Backport of gh-1048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants